fix: resolve all cross-package test failures and type errors#7
Open
stooit wants to merge 1 commit into
Open
Conversation
- Export useSearchDebounce alias from @e2e/utils (renamed hook) - Fix import in apps/web/src/lib/api.ts to use useSearchDebounce - Add aria-label prop passthrough in Button component for accessibility - Fix stale closure in DataTable sort handler using functional state update - Fix date format to use day without leading zero (Australian locale) - Add happy-dom preload to packages/ui/bunfig.toml for DOM test env - Add bun-types to tsconfig.json compilerOptions for bun:test declarations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSearchDebounceas a named re-export from@e2e/utils(the hook was renamed fromuseThrottle/useDebouncebut consumers still imported the old name)apps/web/src/lib/api.tsto importuseSearchDebounceinstead of the non-existentuseThrottlearia-labelfor icon-only buttonsformatDateto output day without leading zero (Australian locale:d/MM/yyyy)happy-dompreload topackages/ui/bunfig.tomlso UI component tests have access todocumentbun-typestotsconfig.jsonsobun:testmodule resolves without type errorsVerification
All 13 tests pass (
bun run test) andtsc --noEmitexits clean.Assumptions
useSearchDebounceis the canonical name; the source was behindd/MM/yyyy) is the intended format based on test expectationsbun-typeswas already installed innode_modules— no new dependency added